-
Notifications
You must be signed in to change notification settings - Fork 13
docs: rewrite typst-docs-web README in English #275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
082b31f
to
a2468e5
Compare
a2468e5
to
3429602
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR rewrites the website README from Japanese to English, providing comprehensive documentation for the typst-docs-web project. The changes transform a minimal Japanese README into a detailed English guide covering setup, configuration, and usage.
Key changes:
- Complete rewrite from Japanese to English
- Added detailed setup instructions with toolchain requirements
- Expanded documentation with configuration examples and project structure
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Hi @YDX-2147483647 @Its-Just-Nans |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could also make the schema available on https://www.schemastore.org/
https://github.com/SchemaStore/schemastore
^^
I just learned about schemastore.org for the first time. This is not a widely known or "standard" application, so I don't think it is necessary at this time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine! Only soft suggestions.
Please see the third comment below.
website/typst-docs-web/README.md
Outdated
<img src="./images/preview.png" alt=""> | ||
</div> | ||
|
||
A generator that builds a website from a documentation JSON file generated by typst-docs. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
website/typst-docs-web/README.md
Outdated
|
||
```json | ||
{ | ||
"$schema": "/path/to/typst-docs-web/metadata.schema.json", |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
bun run test | ||
``` | ||
|
||
## Maintainers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we note the version of typst-docs json somewhere? For example:
The JSON structure generated by typst-docs is not stable.
This project is confirmed to be compatible with typst-docs from v0.13.1 to the dev version on 2025-09-18.
Other versions are usually compatible as well, but they have not been tested carefully.
The typst-docs says the JSON structure is not stable and may change at any time, and it is likely to change soon (because of typst/typst#6922).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's a good idea to clearly state the supported version.
However, since we don't want to update the README too frequently, I believe it's better to mention only the released versions.
The best approach would be to ensure compatibility by running documentation generation tests for the supported versions in CI.
6ffdf6c
to
c19540f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
cf. #233